Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-6338: Fix typo In sort definition #34

Merged
merged 3 commits into from
Nov 20, 2023
Merged

IBX-6338: Fix typo In sort definition #34

merged 3 commits into from
Nov 20, 2023

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Nov 17, 2023 •
edited
Loading

Question Answer
Tickets IBX-6338
Bug fix? no
New feature? no
BC breaks? yes
Tests pass? yes/no
Doc needed? no
License GPL-2.0

Fix typo from #25

  • on several classnames
  • on a function name
  • in translation namespace ibexa_search on a sort_definition family member.

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adriendupuis adriendupuis requested a review from kisztof November 17, 2023 11:19
@adriendupuis adriendupuis changed the title Fix typo In sort definition IBX-6338: Fix typo In sort definition Nov 17, 2023
@adamwojs adamwojs merged commit 0fbe8cc into main Nov 20, 2023
12 checks passed
@adamwojs adamwojs deleted the fix-sort_definition-typo branch November 20, 2023 18:07
@adamwojs
Copy link
Member

Thank you for contribution @adriendupuis!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@kisztof kisztof Awaiting requested review from kisztof

Assignees

@kisztof kisztof

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriendupuis @adamwojs @kisztof @ViniTou