IBX-7419: [autcomplete] Add the total number of results to the autocomplete/suggestions endpoint #38
Conversation
| @@ -47,4 +56,19 @@ public function truncate(int $count): void | |||
| { | |||
| $this->items = array_slice($this->items, 0, $count); | |||
| } | |||
|
|
|||
| public function increaseTotalCount(int $totalCount): void | |||
There was a problem hiding this comment.
Wouldn't increasing totalCount when using append() be less error prone?
There was a problem hiding this comment.
This method is needed because of multiple data sources. When the limit value (for example, 5) is passed, only 5 records will be inserted using the append method. However, it is necessary to include the total number of records that the query finds.
There was a problem hiding this comment.
yeah, I realised that this is probably the case later in the day, wonder how it will work with pagination tho (offset), but I guess this is not something we need (or at all if this works properly), now.
tests/lib/Serializer/Normalizer/Suggestion/SuggestionCollectionNormalizerTest.php
Outdated
Show resolved
Hide resolved
| parent::__construct($items); | ||
| $this->items = $items; | ||
| $this->totalCount = $totalCount; |
There was a problem hiding this comment.
| parent::__construct($items); | |
| $this->items = $items; | |
| $this->totalCount = $totalCount; | |
| parent::__construct($items); | |
| $this->items = $items; | |
| $this->totalCount = $totalCount; |
|
|
||
| public function decreaseTotalCount(int $totalCount): void | ||
| { | ||
| $this->totalCount -= $totalCount; |
There was a problem hiding this comment.
perhaps this will not be the case but maybe something should happen when $this->totalCount will be lower than 0
|
@kisztof the backend endpoint (suggestion) does not return searched contents - frontend does. 
|
…nNormalizerTest.php Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
|
This PR adds new two properties in the suggestion endpoint,
suggestionResultsandtotalCount.http://127.0.0.1:8000/suggestion?query=ala&limit=1{ "suggestionResults": [ { "contentId": 66, "locationId": 67, "contentTypeIdentifier": "article", "name": "abra ala kadabra", "pathString": "2/67", "type": "content", "parentLocations": [ { "id": 52, "locationId": 2, "name": "Ibexa Digital Experience Platform" }, { "id": 66, "locationId": 67, "name": "abra ala kadabra" } ] } ], "resultsCount": 3 }The capability to adjust the totalCount via an extension point can be achieved through the use of
\Ibexa\Contracts\Search\Model\Suggestion\SuggestionCollection::increaseTotalCountor\Ibexa\Contracts\Search\Model\Suggestion\SuggestionCollection::decreaseTotalCountChecklist:
$ composer fix-cs)