Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mapbox tile update #577

Merged
merged 6 commits into from
May 22, 2020
Merged

Mapbox tile update #577

merged 6 commits into from
May 22, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented May 21, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Mapbox is deprecating the tile service datatools-ui currently uses. This PR:

  • updates the URL for Mapbox tiles,
  • consolidates the tile layer props used throughout the app in a single function, and
  • removes updateUserMetadata, which appears to be broken with Auth0 and is essentially just dead code at this point.

NOTE: this requires a configuration change to env.yml:

# previous
MAPBOX_ACCESS_TOKEN: your-token
MAPBOX_MAP_ID: mapbox.streets
MAPBOX_ATTRIBUTION: <a href="https://www.mapbox.com/about/maps/" target="_blank">&copy;
    Mapbox &copy; OpenStreetMap</a> <a href="https://www.mapbox.com/map-feedback/"
    target="_blank">Improve this map</a>
# new: just remove map id and attribution.
MAPBOX_ACCESS_TOKEN: your-token

This feature is no longer working in Auth0. This is essentially dead code and should be added back
only once the user storage is happening in MongoDB.
@evansiroky evansiroky assigned landonreed and unassigned evansiroky May 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #577 into dev will decrease coverage by 21.97%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #577       +/-   ##
===========================================
- Coverage   37.79%   15.82%   -21.98%     
===========================================
  Files         316      315        -1     
  Lines       17304    16085     -1219     
  Branches     5279     4895      -384     
===========================================
- Hits         6540     2545     -3995     
- Misses       9346    11557     +2211     
- Partials     1418     1983      +565     
Flag Coverage Δ
#end_to_end_tests ?
#unit_tests 15.82% <25.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
lib/common/containers/ActiveSidebar.js 100.00% <ø> (ø)
lib/common/user/Auth0Manager.js 10.32% <ø> (-50.58%) ⬇️
lib/editor/components/EditorHelpModal.js 0.00% <ø> (-60.38%) ⬇️
lib/editor/components/GtfsEditor.js 0.00% <ø> (-63.21%) ⬇️
lib/editor/components/map/EditorMap.js 0.00% <0.00%> (-48.94%) ⬇️
...ib/editor/components/map/EditorMapLayersControl.js 0.00% <0.00%> (-47.06%) ⬇️
lib/editor/containers/ActiveGtfsEditor.js 0.00% <ø> (-63.83%) ⬇️
lib/editor/util/map.js 39.14% <ø> (-7.82%) ⬇️
lib/gtfs/components/GtfsMap.js 0.00% <0.00%> (-48.58%) ⬇️
lib/manager/actions/user.js 16.10% <0.00%> (-23.19%) ⬇️
... and 266 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ee966...049231c. Read the comment docs.

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description should have included removal of user metadata and other unused features!

@binh-dam-ibigroup binh-dam-ibigroup removed their assignment May 22, 2020
@landonreed
Copy link
Contributor Author

Sorry that wasn't super clear @binh-dam-ibigroup. Removing the user metadata was in the PR description, but it wasn't in a nice bulleted list so it was easy to miss.

@landonreed landonreed merged commit 7ed815f into dev May 22, 2020
@landonreed landonreed deleted the mapbox-tile-update branch May 22, 2020 19:21
landonreed added a commit that referenced this pull request May 26, 2020
fix(user-update): fix user update error introduced in #577
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants