-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improve handling of forecast variables #356
Milestone
Comments
Initial implementation at https://github.com/ibpsa/project1-boptest/tree/issue356_forecastPoints. Still needs:
|
Closed by #508. |
mattrobmattrob
added a commit
to henze-research-group/MODRLC
that referenced
this issue
Feb 16, 2024
Handle ibpsa/project1-boptest#508 and ibpsa/project1-boptest#356. Default parameters previously from an example RLC simulation on MODRLC: ``` Default Forecast Interval: 3600.0 Default Forecast Horizon: 86400.0 ``` Example parameters from BOPTEST codebase: https://github.com/ibpsa/project1-boptest/blob/2b4328c1607f80a35890968fcac54d7d6c60b965/forecast/forecaster.py#L33-L35 Work towards #51. Signed-off-by: Matt Robinson <mattrob@hey.com>
mattrobmattrob
added a commit
to henze-research-group/MODRLC
that referenced
this issue
Feb 23, 2024
Handle ibpsa/project1-boptest#508 and ibpsa/project1-boptest#356. Default parameters previously from an example RLC simulation on MODRLC: ``` Default Forecast Interval: 3600.0 Default Forecast Horizon: 86400.0 ``` Example parameters from BOPTEST codebase: https://github.com/ibpsa/project1-boptest/blob/2b4328c1607f80a35890968fcac54d7d6c60b965/forecast/forecaster.py#L33-L35 Work towards #51. Signed-off-by: Matt Robinson <mattrob@hey.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Currently,
GET /forecast
returns all data for all forecast variables, which for large data sets leads to a hit on memory and computational time. There is also no documentation in the test cases of which forecast variables are available. This issue is to propose the following improvements:/results
. That is, add an argument that requires specification of the variable wanting to be forecasted and return data for that variable only. One even more backwards-incompatible thought could be to remove the/forecast_parameters
API endpoint and replace with parametershorizon
andinterval
upon retrieving a forecast for a particular variable. These changes combined would then change the forecast API endpoint to resemble thePUT /results
API very closely asPUT /forecast
with argumentspoint_name=<string>
,horizon=<value>
,interval=<value>
.GET /forecast_variables
acting similarly toGET /inputs
andGET /measurements
to retrieve this information programatically.The text was updated successfully, but these errors were encountered: