moved code for how-to-cite to subwidget, include full URL #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTsch
changed the title
StephanMa
reviewed
Jan 6, 2025
There was a problem hiding this comment.
As I can see, you moved this section to another sub widget. Unfortunately, you compute all the necessary data again (fond, collection, etc). Isn't it better just to pass the parts to the sub widget instead of compute them again?
There was a problem hiding this comment.
Ah, I didn't realize it could be done so simply. If I understand correctly, the subwidget automatically looks for variables in the widget it is called from? I've removed the variables from the subwidget, and it seems to work. Could you have another look?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the code for the 'how-to-cite' section to its own subwidget instead of having it in three separate widgets, and adds the full MOM-URL.
Closes #1028.