Make all clippy-suggested functions const

[clubby789]

Addresses #237

[clubby789]

Tested with cargo +1.54 clippy -- -W clippy::missing_const_for_fn

[wtfsck]

Build failed, some of them can't be const. Try with mvex feature enabled too

cargo +1.54 clippy --features "mvex" -- -W clippy::missing_const_for_fn

[clubby789]

Segfault in rustc? 🤔

[wtfsck]

Yes that's weird. I've restarted it, let's see if it still segfaults.

[clubby789]

It happens locally for me too, and I can see some similar issues related to segfaults while compiling to wasm. Maybe an issue with llvm + const?

[wtfsck]

Yeah probably. Will see if I have time later this weekend to figure out which 'const' is the one triggering this segfault.

[wtfsck]

BTW, could you reproduce the crash with 1.54 or did you only try the latest version?

[clubby789]

It only happens under nightly for me, 1.54 and stable both compile fine

[wtfsck]

Maybe your stable isn't 1.61, because that's what CI is using and it crashed both times.

[clubby789]

My stable is 1.60, so I think that's correct. I've filed an issue about the crash at rust-lang/rust#97222

[wtfsck]

Seems like this crash is unrelated to your PR. I've created a new PR to use an older version of rustc when building the JS stuff, if that builds successfully I'll merge this.

[wtfsck]

Thanks, merged it!