Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and improves the cycle detection logic.
Currently, the detector doesn't check inside of sequences, dictionaries, or results, so
struct S { s: Sequence<S> }
won't be caught.This PR improves the detector to check these kinds of things.
Adds a path for the detector to check enums with fields for cycles.
(Currently it does not).
It adds logic to avoid outputting duplicate cycles:
A -> B -> A
andB -> A -> B
are really the same cycle, no point in outputting both.We avoid duplicates by storing sets of cycle elements like
{A, B}
.If we detect a cycle, and it's set of elements has already been reported, we don't report it again.
Fixes #683.