Feature: Support no container ("firefox-default") selection #7
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify `toContainerInfo` function to return `null` when input value is `null`. - Add logic to handle requests with `null` container info by opening them in the default container and removing the original tab. - Ensure `tab` is retrieved before container checks and actions in `onBeforeRequest` function.
|
It might be a few days before I have time to pull this down and play with it. |
|
This works great! I'm going to merge as-is and make a some small tweaks. |
|
I've submitted v1.2 of the addon for review. It should be available within a few days (max). Thanks for the contribution. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6. This should allow users to select no container.