Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #2379: Keep return statements around in original form for ConditionDetection #2425

Merged
merged 5 commits into from
Jun 3, 2021

Conversation

dgrunwald
Copy link
Member

Only transform to fall-through block-exit at the end of the transform pipeline.

This fixes an issue where return statements within try-blocks could turn into goto statements (#2379).

dgrunwald added 5 commits June 2, 2021 22:40
…tionDetection, only transform to fall-through block-exit at the end of the transform pipeline.

This fixes an issue where `return` statements within try-blocks could turn into `goto` statements.
This allows reverting the changes to HighLevelLoopTransform+ReduceNestingTransform from the previous commit, which fixes a bug in loop detection (the previous commit did not handle loops where the loop BlockContainer didn't have a Block as parent).
@dgrunwald dgrunwald merged commit 4045d7e into master Jun 3, 2021
@dgrunwald dgrunwald deleted the fix-2379 branch June 5, 2021 08:32
ElektroKill added a commit to dnSpyEx/ILSpy that referenced this pull request Aug 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant