Support loading compressed Xamarin assemblies, see #2137 #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend class LoadedAssembly to detect and load compressed Xamarin assemblies if direct loading of assembly fails. Requires Nuget pkg K4os.Compression.LZ4 for LZ4 decompression.
Falco20019
reviewed
Aug 4, 2021
ILSpy/LoadedAssembly.cs
Outdated
| var descIdx = fileReader.ReadUInt32(); | ||
| var uncLen = fileReader.ReadUInt32(); | ||
| // fileReader stream position is now at compressed module data | ||
| var src = fileReader.ReadBytes((int)uncLen); // compressed length must be smaller than uncompressed length |
There was a problem hiding this comment.
I would read the complete rest of the file instead of relying on an assumption here. Like using fileStream.Length - 12.
There was a problem hiding this comment.
Thanks, now using fileStream.Length to read all remaining data. Not accounting for compressed header length since ReadBytes() will stop at stream end anyway. We also save us from having a new constant and checking for (theoretical case) fileStream.Length < 12
|
The K4os.Compression.LZ4 license should be added to doc/third-party-notices.txt |
Added license notice for K4os.Compression.LZ4. |
|
Thank you for your contribution! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2137.
Problem
Assemblies included in mobile Android apps created with Xamarin can be compressed. This PR detects compressed assemblies and attempts to decompress them in order to correctly load the assembly. This is handy when analyzing mobile apps created with Xamarin using ILSpy.
Solution
LoadedAssemblyto detect and load compressed Xamarin assemblies if direct loading of assembly fails.