Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add more theme colors #2952

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Conversation

ltrzesniewski
Copy link
Contributor

@ltrzesniewski ltrzesniewski commented Apr 6, 2023

Problem

I missed a few items which themes should have customized in #2906:

  • The current line highlight
  • The line numbers
  • The matching brackets

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.

    The changes are pretty straightforward.

  • Which part of this PR is most in need of attention/improvement?

    I also aligned the borders of highlighted brackets to whole pixels, as they were blurry otherwise.

Render examples:

image image

@siegfriedpammer siegfriedpammer merged commit 6de61cf into icsharpcode:master Apr 7, 2023
@ltrzesniewski ltrzesniewski deleted the themes-fixes branch April 7, 2023 09:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants