Merge PR #444: Multi-target unit tests for .NET Core 2.0 and .NET FW 4.6

icsharpcode · Apr 12, 2020 · b54b511 · b54b511
1 parent fed3bd2
commit b54b511
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/test/ICSharpCode.SharpZipLib.Tests/ICSharpCode.SharpZipLib.Tests.csproj b/test/ICSharpCode.SharpZipLib.Tests/ICSharpCode.SharpZipLib.Tests.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Library</OutputType>
-    <TargetFramework>netcoreapp2.0</TargetFramework>
+		<TargetFrameworks>netcoreapp2.0;net46</TargetFrameworks>
     <ApplicationIcon />
     <StartupObject />
   </PropertyGroup>
@@ -18,6 +18,7 @@
     <PackageReference Include="PublishCoverity" Version="0.11.0" />
     <PackageReference Include="ReportGenerator" Version="2.5.10" />
     <PackageReference Include="System.Text.Encoding.CodePages" Version="4.4.0" />
+    <PackageReference Include="System.ValueTuple" Version="4.5.0" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/test/ICSharpCode.SharpZipLib.Tests/Zip/FastZipHandling.cs b/test/ICSharpCode.SharpZipLib.Tests/Zip/FastZipHandling.cs
@@ -223,7 +223,7 @@ private void TestFileNames(IEnumerable<string> names)
 
 						Assert.AreEqual(name, entry.Name);
 
-						var nameBytes = string.Join(' ', Encoding.BigEndianUnicode.GetBytes(entry.Name).Select(b => b.ToString("x2")));
+						var nameBytes = string.Join(" ", Encoding.BigEndianUnicode.GetBytes(entry.Name).Select(b => b.ToString("x2")));
 
 						Console.WriteLine($" - Zip entry: {entry.Name} ({nameBytes})");
 					}