Fix ZipEntry name mismatch when attempting to update a directory entry #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piksel
reviewed
Jan 25, 2019
piksel
reviewed
Jan 26, 2019
| @@ -1579,7 +1579,7 @@ private void AddUpdate(ZipUpdate update) | |||
| { | |||
| contentsEdited_ = true; | |||
|
|
|||
| int index = FindExistingUpdate(update.Entry.Name); | |||
| int index = FindExistingUpdate(update.Entry); | |||
There was a problem hiding this comment.
Why is FindExistingUpdate changed here?
The FindExistingUpdate(ZipEntry) method should probably just call FindExistingUpdate(string) for DRYness, but that's for another issue...
piksel
reviewed
Jan 26, 2019
| @@ -2511,6 +2513,15 @@ private int FindExistingUpdate(string fileName) | |||
| return result; | |||
| } | |||
|
|
|||
| private bool IsDirectoryName(string name) | |||
There was a problem hiding this comment.
GetTransformedFileName is only referenced in FindExistingUpdate, perhaps GetTransformedFileName, GetTransformedDirectoryName and IsDirectoryName should be reduced to a single function called GetTransformedEntryName? The two former ones are almost identical.
|
Closing due to lack of response. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.