Do not set the StrongEncryption flag for WinZipAes encrypted entries #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ZipEntry.ProcessAESExtraData to not set the StrongEncryption flag for WinZipAes encrypted entries.
As mentioned in #317, setting the StrongEncryption flag in ProcessAESExtraData doesn't seem correct.
This changes that, and rearranges CreateAndInitDecryptionStream to check for the compression method being WinZipAES rather than for the StrongEncryption flag being set.
This will throw if the archive is really using the PKWare strong encryption, which I think is correct if that isn't actually supported?
Related to this: I'm not sure if the
in ProcessAESExtraData is correct either (what happens if the existing version is greater than that?). Maybe needs a seperate change?
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.