Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add [MemoryDiagnoser] to the zip input/output stream benchmark classes #488

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Jul 24, 2020

(And move the allocation of the read buffer out of the benchmark function).

This enables memory allocation diagnostics in the result output, e.g.

|               Method |        Job |     Toolchain |     Mean |   Error |  StdDev | Ratio | Gen 0 | Gen 1 | Gen 2 | Allocated |
|--------------------- |----------- |-------------- |---------:|--------:|--------:|------:|------:|------:|------:|----------:|
| WriteZipOutputStream | Job-ZVUVIV | .NET Core 2.1 | 700.4 ms | 3.39 ms | 3.18 ms |  1.00 |     - |     - |     - | 354.09 KB |
| WriteZipOutputStream | Job-DWFYDH | .NET Core 3.1 | 716.9 ms | 4.67 ms | 3.90 ms |  1.02 |     - |     - |     - | 354.08 KB |
| WriteZipOutputStream | Job-RVPCBW |        net461 | 701.0 ms | 1.57 ms | 1.47 ms |  1.00 |     - |     - |     - | 360.28 KB |

which can be useful for comparing effects of changes/optimizations etc

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel piksel merged commit fd9e8a8 into icsharpcode:master Aug 7, 2020
@Numpsy Numpsy deleted the rw/memory_bench branch August 7, 2020 22:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants