fix(zip): handle iterating updated entries in ZipInputStream #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
+ Coverage 74.54% 74.60% +0.05%
==========================================
Files 72 72
Lines 8450 8457 +7
==========================================
+ Hits 6299 6309 +10
+ Misses 2151 2148 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
piksel
commented
Aug 12, 2021
piksel
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ZipInputStreamexpects all archive entries to immediately follow the previous one. This is normally the case for archives created in one go, but necessarily true when they have been updated.This PR allows
ZipInputStreamto skip any padding between entries and consequently read "direct-updated" archives.Fixes #639
Curiously, 7-zip does not seem to handle these files either and just show all entries found before the first "padded" one. And of course, when updating it uses the equivalent of
ZipFilesFileUpdateMode.Safeto avoid the issue.