Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix name of FT sensors in FT sensor orientation test in ergocub-model-test.cpp #166

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Sep 1, 2023

#158 silently changed the name of the FT sensors, i.e.:

  • ergocub-software <= 0.3.3 names : l_arm_ft_sensor, r_arm_ft_sensor, l_leg_ft_sensor, l_foot_front_ft_sensor, l_foot_rear_ft_sensor, r_leg_ft_sensor, r_foot_front_ft_sensor, r_foot_rear_ft_sensor
  • ergocub-software >= 0.3.4 names : l_arm_ft, r_arm_ft, l_leg_ft, l_foot_front_ft, l_foot_rear_ft, r_leg_ft, r_foot_front_ft, r_foot_rear_ft

However, the names used in the ergocub-model-test.cpp were not updated. However, the tests were silently skipped due to the following logic, that skipped a test if a sensor was not present:

    // Depending on the ergocub model, the sensor could be absent
    if (!comp.model().isFrameNameUsed(sensorName))
    {
        return true;
    }

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Nicogene Nicogene merged commit fb12fa7 into master Sep 1, 2023
@Nicogene Nicogene deleted the traversaro-patch-1 branch September 1, 2023 09:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants