Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update documentation #48

Merged
merged 14 commits into from
Jul 25, 2022
Merged

Update documentation #48

merged 14 commits into from
Jul 25, 2022

Conversation

mattbrannon
Copy link
Contributor

This PR attempts to simplify the process of setting up a new project with the vs-code-prettier-eslint extension. Changes to the README.md include the following:

  • A general restructuring of the document.
    • The example projects and troubleshooting sections are moved to the end of the document.
    • The installation and setup sections are moved to the beginning
  • The sections detailing installation and setup and have been mostly rewritten.

Moving the troubleshooting and examples sections to the end and the installation section to the beginning allows the reader to read from top to bottom without as much jumping back and forth between sections.

The goal of the rewrite is help people get things installed and setup as quickly and easily as possible. Code examples are provided that users can copy/paste directly into their terminal. The section detailing setup includes a json snippet that users can paste directly into their workspace settings. A link to the troubleshooting section is also provided in case something goes wrong.

It's quite a big change to the current documentation so please let me know what you think. Any and all feedback is welcome.

- Rewrite section Installation to include a quickstart guide with
ordered steps and copy/paste code code examples

- Move sections Example projects and Troubleshooting near the end

- Move section Support for earlier versions after Troubleshooting
Copy link
Owner

@idahogurl idahogurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt for the PR! This does look better. The reasoning behind putting the troubleshooting and example projects first was that I got so many issues where people wouldn't even check the troubleshooting section before they created an issue. Perhaps I should include them in the Issue Template.

Could we put a TOC with some of the 2nd level headers as links (Installation, Configuration, Troubleshooting, Example Projects)

mattbrannon and others added 6 commits July 25, 2022 13:58
Capitalize heading

Co-authored-by: Rebecca Vest <olserebe@hotmail.com>
Update heading

Co-authored-by: Rebecca Vest <olserebe@hotmail.com>
Co-authored-by: Rebecca Vest <olserebe@hotmail.com>
Co-authored-by: Rebecca Vest <olserebe@hotmail.com>
Co-authored-by: Rebecca Vest <olserebe@hotmail.com>
@mattbrannon mattbrannon requested a review from idahogurl July 25, 2022 19:25
@mattbrannon
Copy link
Contributor Author

mattbrannon commented Jul 25, 2022

@idahogurl Apologies for the late response. Those were all good suggestions. Let me know if there's anything I missed.

@idahogurl idahogurl merged commit 20b5c0d into idahogurl:master Jul 25, 2022
@idahogurl
Copy link
Owner

Closes #46

@github-actions
Copy link

🎉 This PR is included in version 5.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 25, 2022
@mattbrannon mattbrannon deleted the docs branch July 26, 2022 03:24
@mattbrannon mattbrannon restored the docs branch July 26, 2022 03:24
@mattbrannon
Copy link
Contributor Author

Could we put a TOC with some of the 2nd level headers as links (Installation, Configuration, Troubleshooting, Example Projects)

@idahogurl I completely missed your request before submitting my final request for a review of changes. My apologies for that. I see that you implemented it yourself though. It looks great! Thanks for accepting the PR. I hope it helps reduce some of the complexity with installing and configuring everything. I love this extension. It's the default for all my personal projects. Thanks for making it and thanks for allowing me to contribute to it!

@idahogurl
Copy link
Owner

@mattbrannon No worries! You did most of the heavy lifting. Thanks for the PR again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants