Fix tests breaking with parallel and recover flags #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaibhave
added a commit
to chaibhave/TMAP8
that referenced
this pull request
Apr 4, 2024
|
Job Documentation on 7c274aa wanted to post the following: View the site here This comment will be updated on new commits. |
chaibhave
changed the title
chaibhave
added a commit
to chaibhave/TMAP8
that referenced
this pull request
Apr 4, 2024
simopier
reviewed
Apr 4, 2024
… sievert tests to only run with replicated meshes.
|
These tests need further improvements (which will be dealt with in the PR for #123 ), but for now this fixes the tests that were breaking in parallel runs, distributed meshes or with the recovery options. |
|
@cticenhour can you also review this and make sure if it's sufficient to close #112 ? |
simopier
approved these changes
Apr 5, 2024
test/tests/interfacekernels/InterfaceSorptionSievert/interface_sorption_Sievert.i
Outdated
Show resolved
Hide resolved
simopier
requested changes
Apr 5, 2024
Co-authored-by: Pierre-Clement Simon <pierreclement.simon@gmail.com>
simopier
approved these changes
Apr 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #112
Reason
TMAP8 tests are failing with -p 2 --n-threads 2.
Design
Impact
Fixing broken tests will build confidence in TMAP8 results with larger problems that require parallel and recovery features.