Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Documentation for validation cases 1a-1d #18

Merged
merged 1 commit into from
May 5, 2022

Conversation

singhgp4321
Copy link
Collaborator

@singhgp4321 singhgp4321 commented Mar 22, 2022

#12

Add documentation for case 1a, 1b, 1c and 1d.

@lindsayad
Copy link
Member

@singhgp4321 thank you so much for adding these contributions. Can you make sure that your commit contains an issue reference? E.g. you can run git commit --amend and make sure somewhere in the commit message you put "#12"

@singhgp4321 singhgp4321 force-pushed the Documentation_val1 branch 3 times, most recently from 503c81d to 99f0103 Compare March 28, 2022 07:57
@singhgp4321 singhgp4321 changed the title Draft: Documentation for validation cases 1-3 Documentation for validation cases 1-3 Mar 28, 2022
@singhgp4321 singhgp4321 changed the title Documentation for validation cases 1-3 Documentation for validation cases 1a-1c Mar 28, 2022
@singhgp4321
Copy link
Collaborator Author

@lindsayad Issue reference added.

@moosebuild
Copy link

moosebuild commented Mar 28, 2022

Job Documentation on 8900cea wanted to post the following:

View the site here

This comment will be updated on new commits.

@lindsayad
Copy link
Member

The val-1c test result looked it changed a lot ... but you didn't change anything 🤔 I don't know what's going on there. Will have to investigate more. It looks like you deleted the val-1d.md file. Was that intentional? With the changes/additions made to the val-1b.i input we will have to regold that.

@singhgp4321
Copy link
Collaborator Author

val-1d.md was mistakenly deleted, now it's back. Still need to add a couple of comparison plots in that md file; working on it . . .
I'll look into val-1c and will regold 1b.

@lindsayad
Copy link
Member

if you want some help looking into val-1c let me know

@singhgp4321 singhgp4321 changed the title Documentation for validation cases 1a-1c Documentation for validation cases 1a-1d Apr 14, 2022
@singhgp4321 singhgp4321 force-pushed the Documentation_val1 branch 3 times, most recently from 8e4056e to 4d258bf Compare April 14, 2022 21:35
@singhgp4321
Copy link
Collaborator Author

  • val-1b regolded
  • documentation added to the val-1d.md including the comparison plots
  • val-1c_out.e was diffing probably because of my mistake; it should pass now

For some reason, the comparison of val-1d results with the analytical solution does not look impressive (val-1d_comparison_diffusion.png). I suspect that some parameter used in the analytical solution (see comparison_val-1d.py) is not what it should be.

@lindsayad
Copy link
Member

This is really nice documentation @singhgp4321. I'm super impressed. Probably better than any doc I've ever made 😆 We should try and look into the 1d discrepancies, but that is another task. Thank you!!

@lindsayad lindsayad merged commit 317572e into idaholab:devel May 5, 2022
@singhgp4321
Copy link
Collaborator Author

Haha 😆 You're welcome! Let's touch base sometime next week for implementing the other validation cases. You had mentioned that probably we'll need to develop kernels for the other cases.

@lindsayad
Copy link
Member

lindsayad commented May 13, 2022 via email

@singhgp4321 singhgp4321 deleted the Documentation_val1 branch July 30, 2022 21:33
lindsayad pushed a commit to RemDelaporteMathurin/TMAP8 that referenced this pull request Nov 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants