Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding non-conda pip package building script. #2259

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

joshua-cogliati-inl
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl commented Feb 15, 2024

On arm on mac, we had errors with conda built packages linking the wrong libc++.1.0.dylib and failing to install.


Pull Request Description

What issue does this change request address?

Closes #2258

What are the significant changes in functionality due to this change request?

Adds a script that can build the pip packages with an existing python3.9 and python3.10 script.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

On arm on mac, we had errors with conda built packages linking the
wrong libc++.1.0.dylib and failing to install.
Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.

@moosebuild
Copy link

Job Test qsubs sawtooth on 88c5fb1 : invalidated by @wangcj05

It seems there is some issue with qsub test, over 3hrs for only 182 tests.

@moosebuild
Copy link

Job Test qsubs sawtooth on 88c5fb1 : invalidated by @joshua-cogliati-inl

failed in fetch

@wangcj05
Copy link
Collaborator

checklist is good.

@wangcj05 wangcj05 merged commit 11e4ca0 into idaholab:devel Feb 16, 2024
12 checks passed
@joshua-cogliati-inl joshua-cogliati-inl deleted the alt_pip_package branch February 19, 2024 22:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Script to build packages without conda
3 participants