Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Route53 record dependencies #43

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

amontalban
Copy link
Contributor

@amontalban amontalban commented Aug 3, 2023

Without this the module was trying to create Elasticsearch resources before the DNS entry and therefore the cluster was created:

module.acm[0].aws_acm_certificate_validation.this[0]: Creating...
module.acm[0].aws_acm_certificate_validation.this[0]: Creation complete after 0s [id=2023-08-03 19:26:52.495 +0000 UTC]

Error: Get "https://elk.domain.com/": dial tcp: lookup elk.domain.com on 10.1.0.2:53: no such host

  with elasticsearch_index_template.index_template["live_transcription_events"],
  on index_template.tf line 1, in resource "elasticsearch_index_template" "index_template":
   1: resource "elasticsearch_index_template" "index_template" {

With this change the Cluster is created, then the Route53 host and all Elasticsearch resources are created properly.

Additionally, I added a change to the examples folder to make sure tflint checks pass.

The Elasticsearch resources should depend on Route53 record so the provider
can connect to it.
@amontalban
Copy link
Contributor Author

@steveteuber @smlgbl can you please review this PR and let me know if it makes sense to be merged? Thanks!

@steveteuber steveteuber merged commit 0346090 into idealo:main Sep 1, 2023
@steveteuber
Copy link
Member

Hi @amontalban, thanks for your pull request. Merged!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🎉 This PR is included in version 1.4.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

steveteuber pushed a commit to mikstew/terraform-aws-opensearch that referenced this pull request Sep 1, 2023
* fix: Elasticsearch resources should depend on R53

The Elasticsearch resources should depend on Route53 record so the provider
can connect to it.

* fix: Add HTTP provider version to fix tflint warn
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants