Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ base ] Add getThreadId #3494

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Matthew-Mosior
Copy link
Contributor

Description

This PR adds the getThreadId function to System.Concurrency (chez backend).

Should this change go in the CHANGELOG?

  • If this is a fix, user-facing change, a compiler change, or a new paper
    implementation, I have updated CHANGELOG_NEXT.md (and potentially also
    CONTRIBUTORS.md).

@Matthew-Mosior Matthew-Mosior changed the title [ base ] Adding getThreadId thread primitive. [ base ] Adding getThreadId Feb 18, 2025
@Matthew-Mosior Matthew-Mosior changed the title [ base ] Adding getThreadId [ base ] Add getThreadId Feb 18, 2025
@Matthew-Mosior
Copy link
Contributor Author

I think channels008 is the issue here on the windows-bootstrap-chez workflow.

@Matthew-Mosior
Copy link
Contributor Author

Should be ready for review.

@cypheon
Copy link
Contributor

cypheon commented Feb 20, 2025

Should this function maybe rather return a value of type PrimIO.ThreadID (the same type as returned by fork when creating a new thread) instead of Int?

@Matthew-Mosior
Copy link
Contributor Author

Matthew-Mosior commented Feb 20, 2025

Should this function maybe rather return a value of type PrimIO.ThreadID (the same type as returned by fork when creating a new thread) instead of Int?

Hmm, it appears there isn't a way to show a ThreadID, as its an opaque thread object in scheme.

Is this what we want here? I think it would be great to be able to somehow show and/or cast this value (to be able to create hashes off of, etc.). Thinking about use and testing here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants