[ fix ] Forward data declarations are linear #3495
Open
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #586 and #1204 (included as tests). The occurs because forward data declarations are tagged as
linear, I have changed it totop. I don't know why they were tagged aslinearin the first place, so there is a chesterton's fence situation here, but if #586 is a bug then they probably should not be. If they were marked linear to distinguish forward declarations from empty types, that is now handled by #3480.Previously, the following code would error with "Trying to use linear name Main.X in non-linear context." It now checks.