Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add before_save hook #201

Merged
merged 2 commits into from
Jan 19, 2020
Merged

Add before_save hook #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87c1a2
add `before_save` hook
igor-makarov Jan 19, 2020
30320fa
add test for `before_hook`
igor-makarov Jan 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/xcake/dsl/project/hooks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ class Project
include Hooks
include Hooks::InstanceHooks

# Defines hook which is ran before project is saved.
#
define_hooks :before_save

# Defines hook which is ran after project is saved.
#
define_hooks :after_save
Expand Down
1 change: 1 addition & 0 deletions lib/xcake/generator/project_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ def self.dependencies

def leave_project(project)
native_project = @context.native_object_for(project)
project.run_hook :before_save, native_project
native_project.save
project.run_hook :after_save

Expand Down
5 changes: 5 additions & 0 deletions spec/generator/project_generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ module Xcake
@generator.leave_project(@dsl_project)
end

it 'should run the before save hook' do
expect(@dsl_project).to receive(:run_hook).with(:before_save, @project)
@generator.leave_project(@dsl_project)
end

it 'should run the after save hook' do
expect(@dsl_project).to receive(:run_hook).with(:after_save)
@generator.leave_project(@dsl_project)
Expand Down