Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Models and Schemas, Batch 3: Task Management #140

Merged
merged 7 commits into from
Aug 11, 2024

Conversation

slaarti
Copy link
Contributor

@slaarti slaarti commented Jul 29, 2024

Description

This is the third batch of models and schemas for #72, making up something like a simple task management system.

Changes

Models, schemas, and doc/docstring updates for:

  • Tier
  • Department
  • User
  • Story (Replacement for Project in this model set to reduce confusion with the Project that's part of the models defined in tests.)
  • Task

One thing I want to note is that, in docs/advanced/joins.md, the examples between the "Getting Joined Data Nested" section and the later "One-to-One Relationships" appear to be identical? It feels unnecessarily redundant to me, but I'm not sure what to do about it. I just wanted to get it noted for the review and see if anyone else who reads this has any ideas.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added necessary documentation (if appropriate).

@igorbenav
Copy link
Owner

One thing I want to note is that, in docs/advanced/joins.md, the examples between the "Getting Joined Data Nested" section and the later "One-to-One Relationships" appear to be identical

True, I belive one of those was in another page, probably Advanced CRUD usage, and eventually I changed and didn't notice the repetition.

How would you like to proceed, @slaarti?

slaarti added 7 commits August 9, 2024 09:19
Replacement for `Project` in this model set to reduce confusion with the
`Project` that's part of the models defined in tests.
One thing I want to note is that, in `docs/advanced/joins.md`, the
examples between the "Getting Joined Data Nested" section and the later
"One-to-One Relationships" appear to be identical? It feels
unnecessarily redundant to me, but I'm not sure what to do about it. I
just wanted to get it noted for the review and see if anyone else who
reads this has any ideas.
@igorbenav igorbenav merged commit 6416f89 into igorbenav:main Aug 11, 2024
7 checks passed
@slaarti
Copy link
Contributor Author

slaarti commented Aug 11, 2024

Sorry, right, I meant to say that you might as well go ahead and merge, since this PR didn't really touch that and I forget if one of the later ones to come do either. If none of them do, then I suppose that's something to maybe work on after #72 is closed out.

@slaarti slaarti deleted the models_taskmgt branch August 11, 2024 13:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants