refactor: use %||% from rlang #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
|
@krlmlr thanks for reporting r-lib/roxygen2#1570, seeing it made me fix the problem much quicker 😅 |
maelle
commented
Jan 16, 2024
| } | ||
| } | ||
| } | ||
|
|
||
| `%&&%` <- function(lhs, rhs) { |
There was a problem hiding this comment.
@krlmlr does this operator exist in other packages? even as utility, I had never seen it.
There was a problem hiding this comment.
krlmlr
approved these changes
Jan 16, 2024
| } | ||
| } | ||
| } | ||
|
|
||
| `%&&%` <- function(lhs, rhs) { |
There was a problem hiding this comment.
aviator-app
bot
force-pushed
the
rlang-op
branch
from
36171e0 to
4e04d26
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
later this will be from base R itself 😁
I noticed this function's name in the "sanitizer" workflow results and while looking for occurrences of it in the codebase, I saw it was home-made.