Migrate to Click #428
Merged
Migrate to Click #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to return 3000 when running locally on localhost:3000
These will be replaced by simpler and more useful integration tests.
ihabunek
force-pushed
the
click
branch
2 times, most recently
from
60da88c to
f4b0443
Compare
I was told there are legitimate use cases I was not aware of.
The old way did not allow for having multiple commands of the same name
|
I merged this now to avoid having a long running branch. The few changes which need to be implemented before release can be done on master. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite toot to use Click.
TODO before merging:
--quietflag, currently does nothing[tui]category in settings in favour of[commands.tui][commands.*]sections in favour of[toot.*]?fixes #375