Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hack to make full discography work #233

Closed
wants to merge 1 commit into from
Closed

Conversation

kjake
Copy link
Contributor

@kjake kjake commented Aug 23, 2024

In my testing the urls list often (always?) contains a top-level url of the artist without any albums or tracks, and is the first in the list, causing bandcamp-dl to immediately fail.

This could potentially be fixed in get_full_discography(), but I'm not that good at python.

In my testing the `urls` list often (always?) contains a top-level url of the artist without any albums or tracks, and is the first in the list, causing `bandcamp-dl` to immediately fail.

This could potentially be fixed in get_full_discography(), but I'm not that good at python.
@Evolution0 Evolution0 mentioned this pull request Sep 11, 2024
@Evolution0
Copy link
Collaborator

Evolution0 commented Sep 11, 2024

get_full_discography() is only used when a user specifies an artist name rather than providing a url (using --artist) unless doing so is what you meant.

If you mean even attempting to provide a url directly somehow chucks a toplevel artist page url into the urls list then that is a genuine issue.

Have you tested what happens with this change to other download processes? (providing a track or album url directly, providing artist and album or track name via --artist --album --track)

@Evolution0 Evolution0 closed this Sep 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants