stop writing seed/draw to simulation results #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
hussain-jafari
approved these changes
Jun 18, 2024
rmudambi
approved these changes
Jun 20, 2024
…vivarium into feature/sbachmei/MIC-5116-remove-seed-draw-from-results-cols
stevebachmeier
merged commit 8fb657c
into
epic/MIC-4968-results-processing
6 checks passed
stevebachmeier
deleted the
feature/sbachmei/MIC-5116-remove-seed-draw-from-results-cols
branch
stevebachmeier
added a commit
that referenced
this pull request
Jul 8, 2024
* stop writing seed/draw to simulation results * pin numpy<2.0.0
stevebachmeier
added a commit
that referenced
this pull request
Jul 12, 2024
* stop writing seed/draw to simulation results * pin numpy<2.0.0
stevebachmeier
added a commit
that referenced
this pull request
Aug 13, 2024
* stop writing seed/draw to simulation results * pin numpy<2.0.0
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include seed/draw in results
Description
Changes and notes
This just removes including seed and draw columns for single-simulationresults. They are unnecessary since we already write out the finalized
simulation configuration and they result in duplicate columns in parallel
simulation results
Testing
tests updated and pass