remove StratifiedObserver #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
rmudambi
approved these changes
Jun 20, 2024
hussain-jafari
approved these changes
Jun 20, 2024
…vivarium into feature/sbachmei/remove-StratifiedObserver
stevebachmeier
merged commit b9c8d8a
into
epic/MIC-4968-results-processing
6 checks passed
stevebachmeier
added a commit
that referenced
this pull request
Jul 8, 2024
stevebachmeier
added a commit
that referenced
this pull request
Jul 12, 2024
stevebachmeier
added a commit
that referenced
this pull request
Aug 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove StratifiedObserver
Description
Changes and notes
We weren't gaining much by having StratifiedObserver and it just seemed
weird to have that when we already have a stratified vs unstratified concept
built into the different observation types.
The weird thing here, though, is now that non-stratified Observers have this
configuration default "stratifications" floating around that just aren't being used.
Testing
tests pass.