raise when registering an observation name duplicate #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
hussain-jafari
approved these changes
Jul 12, 2024
albrja
approved these changes
Jul 12, 2024
stevebachmeier
deleted the
feature/sbachmei/MIC-5048-handle-duplicate-observation-names
branch
stevebachmeier
added a commit
that referenced
this pull request
Aug 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise when duplicate observation name
Description
Changes and notes
This PR prevents identically-named observations from being registeredsince those observation names are eventually what the results file
is called. And by extension, we no longer allow completely duplicate
observations to be registered (which previously just overwrote each other
so that only one "version" was registered)
Testing
replaced a duplicate observation test with a test that asserts
the raise triggers