Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

mypy fix index_map.py #482

Merged
merged 3 commits into from
Sep 20, 2024
Merged

mypy fix index_map.py #482

merged 3 commits into from
Sep 20, 2024

Conversation

stevebachmeier
Copy link
Contributor

Mypy: fix index_map.py

Description

Changes and notes

Testing

rmudambi
rmudambi reviewed Sep 19, 2024
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
src/vivarium/framework/randomness/index_map.py Outdated Show resolved Hide resolved
src/vivarium/framework/randomness/index_map.py Outdated Show resolved Hide resolved
src/vivarium/framework/randomness/index_map.py Show resolved Hide resolved
src/vivarium/framework/randomness/index_map.py Show resolved Hide resolved
src/vivarium/framework/randomness/index_map.py Outdated Show resolved Hide resolved
src/vivarium/framework/randomness/index_map.py Outdated Show resolved Hide resolved
tests/framework/randomness/test_index_map.py Show resolved Hide resolved
rmudambi
rmudambi approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rmudambi rmudambi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to merge/release until my forthcoming PR get approved.

src/vivarium/framework/randomness/index_map.py Outdated Show resolved Hide resolved
@stevebachmeier stevebachmeier merged commit 25cd815 into main Sep 20, 2024
6 checks passed
@stevebachmeier stevebachmeier deleted the feature/sbachmei/MIC-5346-mypy-index-map branch September 20, 2024 21:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@patricktnast patricktnast patricktnast approved these changes

@albrja albrja albrja approved these changes

@rmudambi rmudambi rmudambi approved these changes

@collijk collijk Awaiting requested review from collijk collijk is a code owner

@hussain-jafari hussain-jafari Awaiting requested review from hussain-jafari hussain-jafari is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevebachmeier @rmudambi @albrja @patricktnast