Sbachmei/mic 5395/mypy event #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
albrja
approved these changes
Oct 24, 2024
stevebachmeier
commented
Oct 24, 2024
| #: The simulation time at which this event will resolve. The current | ||
| #: simulation size plus the current time step size. | ||
| # FIXME [MIC-5468]: fix index type hint for mypy | ||
| index: pd.Index[int] # type: ignore[assignment] |
There was a problem hiding this comment.
ignored because NamedTuple has an index method. We can either change the name of this attr or switch to a @dataclass(frozen=True)
stevebachmeier
commented
Oct 24, 2024
| @@ -113,7 +118,7 @@ def emit(self, index: pd.Index, user_data: Optional[Dict] = None) -> Event: | |||
| e = Event( | |||
| index, | |||
| user_data, | |||
| self.manager.clock() + self.manager.step_size(), | |||
| self.manager.clock() + self.manager.step_size(), # type: ignore[operator, arg-type] | |||
There was a problem hiding this comment.
Need to sort out the clock type hints here. They include Number which don't all have add implemented.
patricktnast
approved these changes
Oct 24, 2024
hussain-jafari
approved these changes
Oct 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mypy errors in framework/event.py
Description
Changes and notes
Testing