mypy fixes for boids example #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
stevebachmeier
commented
Dec 26, 2024
| @@ -43,7 +43,7 @@ def on_time_step(self, event: Event) -> None: | |||
| # Pipeline sources and modifiers # | |||
| ################################## | |||
|
|
|||
| def get_neighbors(self, index: pd.Index) -> pd.Series: | |||
| def get_neighbors(self, index: pd.Index[int]) -> pd.Series[list[int]]: # type: ignore[type-var] | |||
There was a problem hiding this comment.
This is that someone common pandas error where it doesn't list out the entire line of expected items:
Type argument "list[int]" of "Series" must be a subtype of "str | bytes | date | time | bool | <10 more items>" [type-var]
stevebachmeier
commented
Dec 26, 2024
| s.set_offsets(frame_pops[i]) | ||
|
|
||
| return FuncAnimation(fig, animate, frames=frames, interval=10) | ||
| return FuncAnimation(fig, animate, frames=frames, interval=10) # type: ignore[arg-type] |
There was a problem hiding this comment.
FuncAnimation has the 2nd arg type-hinted as a callable that returns some obscure thing (certainly not None). It didn't seem worth it for a contrived example like this.
patricktnast
approved these changes
Dec 27, 2024
rmudambi
approved these changes
Dec 27, 2024
CHANGELOG.rst
Outdated
| @@ -1,3 +1,7 @@ | |||
| **3.2.12 - 12/27/24** | |||
There was a problem hiding this comment.
I think you need to merge from main again? I already released 3.2.12
| plt.show() | ||
|
|
||
|
|
||
| def plot_boids_animated(simulation): | ||
| def plot_boids_animated(simulation: InteractiveContext) -> FuncAnimation: |
There was a problem hiding this comment.
Is this an InteractiveContext or a SimulationContext?
There was a problem hiding this comment.
I'm not really sure tbh. The example docs is all about interactive, but maybe it could be used in a simulation context?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy fixes: boids example
Description
Changes and notes
Testing