Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added data-external #52

Merged
merged 2 commits into from
Dec 6, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: vembedr
Title: Embed Video in HTML
Version: 0.1.4.9002
Version: 0.1.4.9003
Authors@R: c(
person(
given = "Ian",
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# vembedr 0.1.4.9000 (development version)

- updates `<iframe>` implementation to keep up with pandoc, see [rstudio/rmarkdown#2255](https://github.com/rstudio/rmarkdown/issues/2255) (#52, @jnolis).

- version bump for development

## vembedr 0.1.4
@@ -17,7 +19,7 @@

## vembedr 0.1.3

- updates README to show some custom formatting (#25, thanks @koncina and @ginolhac)
- updates README to show some custom formatting (#25, @koncina & @ginolhac)
- deprecates `hms()` and `secs()` in favor of `use_start_time()` (#24)
- adds function `embed_user2017()`: embed videos from UseR!2017
- version bump for development
3 changes: 2 additions & 1 deletion R/service-box.R
Original file line number Diff line number Diff line change
@@ -35,7 +35,8 @@ embed_box <- function(id, custom_domain = getOption("vembedr.box_custom_domain")
frameborder = frameborder,
allowfullscreen = allowfullscreen,
webkitallowfullscreen = allowfullscreen,
msallowfullscreen = allowfullscreen
msallowfullscreen = allowfullscreen,
`data-external` = 1
)

embed <- create_embed(iframe, "vembedr_embed_box", ratio)
3 changes: 2 additions & 1 deletion R/service-channel9.R
Original file line number Diff line number Diff line change
@@ -19,7 +19,8 @@ embed_channel9 <- function(id,
width = dim$width,
height = dim$height,
frameborder = frameborder,
allowfullscreen = allowfullscreen
allowfullscreen = allowfullscreen,
`data-external` = 1
)

embed <- create_embed(iframe, "vembedr_embed_channel9", ratio)
3 changes: 2 additions & 1 deletion R/service-msstream.R
Original file line number Diff line number Diff line change
@@ -17,7 +17,8 @@ embed_msstream <- function(id, width = NULL, height = 300,
width = dim$width,
height = dim$height,
allowfullscreen = NULL,
style = "border:none;"
style = "border:none;",
`data-external` = 1
)

embed <- create_embed(iframe, "vembedr_embed_msstream", ratio)
3 changes: 2 additions & 1 deletion R/service-vimeo.R
Original file line number Diff line number Diff line change
@@ -26,7 +26,8 @@ embed_vimeo <- function(id,
frameborder = frameborder,
webkitallowfullscreen = allowfullscreen,
mozallowfullscreen = allowfullscreen,
allowfullscreen = allowfullscreen
allowfullscreen = allowfullscreen,
`data-external` = 1
)

embed <- create_embed(iframe, "vembedr_embed_vimeo", ratio)
3 changes: 2 additions & 1 deletion R/service-youtube.R
Original file line number Diff line number Diff line change
@@ -21,7 +21,8 @@ embed_youtube <- function(id,
width = dim$width,
height = dim$height,
frameborder = frameborder,
allowfullscreen = allowfullscreen
allowfullscreen = allowfullscreen,
`data-external` = 1
)

embed <- create_embed(iframe, "vembedr_embed_youtube", ratio)