Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MAINT: Add dcgain method to State and Transfer #87

Merged
merged 2 commits into from
Apr 26, 2022
Merged

MAINT: Add dcgain method to State and Transfer #87

merged 2 commits into from
Apr 26, 2022

Conversation

ilayn
Copy link
Owner

@ilayn ilayn commented Apr 25, 2022

Not extremely robust evaluation of low frequency value of dynamical models.

Main issue is the integrator/adder cancellations such as Transfer([1, 0], [1, 1, 0]) but direct evaluation at s=0 would give 0/0though having a finite DC gain.

Closes #81

@ilayn ilayn added this to the v1.0.2 milestone Apr 25, 2022
@ilayn
Copy link
Owner Author

ilayn commented Apr 26, 2022

control's implementation is a bit too naive since everything returns inf if A is singular, say if you have the State representation of [1/(s+1), 1/s]. DC Gain should return 1 and inf but instate version A is singular so it returns [inf inf], But I already fixed the DC gain code anyways.

It turns out that my library design was quite bad and lead to circular imports throughout. Hence the delay.

@ilayn ilayn merged commit 237e1d4 into main Apr 26, 2022
@ilayn ilayn deleted the add_dcgain branch April 26, 2022 23:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants