chore: remove unused Cargo features #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-line
force-pushed
the
dev/remove_unused_features
branch
from
ef1bf57 to
678ec90
Compare
ilya-zlobintsev
requested changes
Nov 8, 2024
lact-gui/Cargo.toml
Outdated
| lact-schema = { path = "../lact-schema", features = ["args"] } | ||
| lact-schema = { path = "../lact-schema" } |
There was a problem hiding this comment.
The args feature is actually needed, if you compile just the gui crate (cargo build -p lact-gui) it will fail without it. It's just normally when you build the whole workspace it enables the feature from another crate needing it, so it seems like it works without it.
In-line
force-pushed
the
dev/remove_unused_features
branch
from
678ec90 to
31df717
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decreases size by about 0.1 MB, while reducing compilation time