Fix overflow bug on bogus code lengths #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
When the set of code lengths for the huffman codes encoding the main huffman tables contained a set of lengths that could not create a set of valid codes, the overflow discovered in #14 happened.
This PR checks for the overflow, and returns an error instead of overflowing.
Also added a test to check for the issue.
I don't know if the error message is descriptive enough, or if it ought to be changed.