add missing sample argument to Traceparent.to_value #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
commented
Feb 21, 2025
| @@ -1576,8 +1576,9 @@ module Trace_context = struct | |||
| | Ok sp -> Ok (Span_ctx.trace_id sp, Span_ctx.parent_id sp) | |||
| | Error _ as e -> e | |||
|
|
|||
| let to_value ~(trace_id : Trace_id.t) ~(parent_id : Span_id.t) () : string = | |||
| let span_ctx = Span_ctx.make ~trace_id ~parent_id () in | |||
There was a problem hiding this comment.
Out of curiosity, what was the reason for this last unit argument? Is it because you anticipated this change and didn't want to break the interface ?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I omitted in #83