disqus_identifier set wrong

[willrjmarshall]

Hi,

So, when you're using a page of the format say ... my-page/index.html (after migrating from wordpress), so the url is /my-page.

disqus_identifier will incorrectly be set to /my-page/index.html, instead of /my-page.

This breaks migration from Wordpress/Disqus sites.

[fhemberger]

Can you please try this: In source/_includes/_disqus.html replace

    var disqus_identifier = '{{ site.url }}{{ page.url }}';
    var disqus_url = '{{ site.url }}{{ page.url }}';

with

    var disqus_identifier = '{{ canonical }}';
    var disqus_url = '{{ canonical }}';

[willrjmarshall]

That seems to do the trick. Working example with this patch is here: http://willmarshall.me/dj-template

[fhemberger]

Great. I'll also add a patch so the canonical URL doesn't contain the unnecessary tailing slash any more.

[willrjmarshall]

Excellent! This might break WP transfers as well: depends on how flexible Disqus is with exact URL matching.... but it's cleaner and easy enough to migrate via CSV.

[escobera]

The strip_slashes thing is causing problems on urls that had already created threads on Disqus. The identifier changes, so it creates a new thread.

[fhemberger]

@willrjmarshall, @escobera

Please note the following change (commit 262eb52):
https://github.com/imathis/octopress/wiki/Disqus-identifier-issues

Sorry for the inconvenience.