-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Switch to FastAPI #112
Merged
Merged
Switch to FastAPI #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've swapped target branch here to rework-fastapi. Let's use that branch as target branch for all the PRs that are needed to do the framework switch. When everything is ready we make a big PR from rework-fastapi to master. |
ok |
6f5e711
to
b2e784b
Compare
I changed back target branch to master branch since this should be ready already now. |
Should we merge it now? |
I haven't tested it yet in the browser. If we do that I think we can merge. |
* Add app and client test fixtures * Add starlette to test requirements * Fix views tests * Store settings in app state * Delint * Fix test run * Fix more tests * Delint * Delint * Fix sync connector view * Fix request form lookup
00e09c1
to
d2ff00d
Compare
MartinHjelmare
approved these changes
Feb 27, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.