Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to FastAPI #112

Merged
merged 10 commits into from
Feb 27, 2021
Merged

Switch to FastAPI #112

merged 10 commits into from
Feb 27, 2021

Conversation

oeway
Copy link
Collaborator

@oeway oeway commented Feb 12, 2021

No description provided.

@MartinHjelmare MartinHjelmare changed the base branch from master to rework-fastapi February 13, 2021 14:49
@MartinHjelmare
Copy link
Collaborator

I've swapped target branch here to rework-fastapi. Let's use that branch as target branch for all the PRs that are needed to do the framework switch. When everything is ready we make a big PR from rework-fastapi to master.

@oeway
Copy link
Collaborator Author

oeway commented Feb 13, 2021

ok

imjoy_elfinder/views.py Show resolved Hide resolved
imjoy_elfinder/views.py Show resolved Hide resolved
@MartinHjelmare MartinHjelmare changed the base branch from rework-fastapi to master February 22, 2021 09:16
@MartinHjelmare
Copy link
Collaborator

I changed back target branch to master branch since this should be ready already now.

@oeway
Copy link
Collaborator Author

oeway commented Feb 22, 2021

Should we merge it now?

@MartinHjelmare
Copy link
Collaborator

I haven't tested it yet in the browser. If we do that I think we can merge.

oeway and others added 9 commits February 27, 2021 16:06
* Add app and client test fixtures

* Add starlette to test requirements

* Fix views tests

* Store settings in app state

* Delint

* Fix test run

* Fix more tests

* Delint

* Delint

* Fix sync connector view

* Fix request form lookup
@MartinHjelmare MartinHjelmare merged commit 3f3dff5 into master Feb 27, 2021
@MartinHjelmare MartinHjelmare deleted the fastapi branch February 27, 2021 15:15
@MartinHjelmare MartinHjelmare added the enhancement New feature or request label Feb 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants