Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(web): show stack in album #12276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): show stack in album #12276

wants to merge 1 commit into from

Conversation

alextran1502
Copy link
Contributor

Fixes #12273

Show stacked asset in album and in selection view.

Also fix an issue of the timeline does not appear after adding new assets to the album

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought stacks were only supposed to show up on the main timeline for the given user. Does granting access to a primary asset on a stack (via an album) also now imply read access to every asset in the stack?

@alextran1502
Copy link
Contributor Author

@jrasm91 I was debating this as well. Maybe it makes sense to assume that if you want to put a stack asset in an album, you would want all the stack children to go with it.

I think in real-world use case, the user would typically stack similar photos together

@kvalev
Copy link

kvalev commented Sep 4, 2024

From my point of view (not that anyone is asking :D), if an asset is stacked, it should show up everywhere as stacked - timeline, albums, places, people. I personally stack very similar/identical pictures together, so for me the stack represents a single asset that, for one reason or another, I decided to keep multiple copies of. However, I dont want to have my albums (automatically created from folders in an external library) or timeline spammed with multiple similarly looking pictures, hence why I stack them.

@akostadinov
Copy link

akostadinov commented Sep 11, 2024

Does this change mobile behavior as well?

UPDATE: I see now PR #12279 so it will be changed on mobile as well.

I see this should also fix #6387 and #10135

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacked Photo not grouped in albums
4 participants