Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove public. reference in migration sql #12285

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

alextran1502
Copy link
Contributor

Fix #12282

Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove it for earlier migrations too, right?

@alextran1502
Copy link
Contributor Author

@mertalev This is the only occurence

@alextran1502 alextran1502 merged commit a96f41a into main Sep 3, 2024
28 of 29 checks passed
@alextran1502 alextran1502 deleted the remove-public-reference branch September 3, 2024 21:42
@lezruk
Copy link
Contributor

lezruk commented Sep 4, 2024

We should remove it for earlier migrations too, right?

There are few, they are for previous releases not sure if still relevant, but on older releases upgrades/migrations these (drop index with "public" in quotes) were failling as well.

node@immich-server-5988b7859c-r9gx6:/usr/src/app/dist/migrations$ grep "\"public\"\." *
1661881837496-AddAssetChecksum.js:        await queryRunner.query(`DROP INDEX "public"."IDX_64c507300988dd1764f9a6530c"`);
1670257571385-CreateTagsTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_e99f31ea4cdf3a2c35c7287eb4"`);
1670257571385-CreateTagsTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_f8e8a9e893cb5c54907f1b798e"`);
1673150490490-AddSharedLinkTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_c9fab4aa97ffd1b034f3d6581a"`);
1673150490490-AddSharedLinkTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_5b7decce6c8d3db9593d6111a6"`);
1673150490490-AddSharedLinkTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_sharedlink_key"`);
1675812532822-FixAlbumEntityTypeORM.js:        await queryRunner.query(`DROP INDEX "public"."IDX_427c350ad49bd3935a50baab73"`);
1675812532822-FixAlbumEntityTypeORM.js:        await queryRunner.query(`DROP INDEX "public"."IDX_f48513bf9bccefd6ff3ad30bd0"`);
1675812532822-FixAlbumEntityTypeORM.js:        await queryRunner.query(`DROP INDEX "public"."IDX_e590fa396c6898fcd4a50e4092"`);
1675812532822-FixAlbumEntityTypeORM.js:        await queryRunner.query(`DROP INDEX "public"."IDX_4bd1303d199f4e72ccdf998c62"`);
1676437878377-AppleContentIdentifier.js:        await queryRunner.query(`DROP INDEX "public"."IDX_live_photo_cid"`);
1676848629119-ExifEntityDefinitionFixes.js:        await queryRunner.query(`DROP INDEX "public"."IDX_c0117fdbc50b917ef9067740c4"`);
1676852143506-SmartInfoEntityDefinitionFixes.js:        await queryRunner.query(`DROP INDEX "public"."IDX_5e3753aadd956110bf3ec0244a"`);
1677535643119-AddIndexForAlbumInSharedLinkTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_sharedlink_albumId"`);
1684328185099-RequireChecksumNotNull.js:        await queryRunner.query(`DROP INDEX "public"."IDX_64c507300988dd1764f9a6530c"`);
1684328185099-RequireChecksumNotNull.js:        await queryRunner.query(`DROP INDEX "public"."IDX_8d3efe36c0755849395e6ea866"`);
1692804658140-AddAuditTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_ownerId_createdAt"`);
1696888644031-AddOriginalPathIndex.js:        await queryRunner.query(`DROP INDEX "public"."IDX_originalPath_libraryId"`);
1698693294632-AddActivity.js:        await queryRunner.query(`DROP INDEX "public"."IDX_activity_like"`);
1700752078178-AddAssetFaceIndicies.js:        await queryRunner.query(`DROP INDEX "public"."IDX_b463c8edb01364bf2beba08ef1"`);
1700752078178-AddAssetFaceIndicies.js:        await queryRunner.query(`DROP INDEX "public"."IDX_bf339a24070dac7e71304ec530"`);
1701665867595-AddExifCityIndex.js:        await queryRunner.query(`DROP INDEX "public"."exif_city"`);
1703035138085-AddAutoStackId.js:        await queryRunner.query(`DROP INDEX "public"."IDX_auto_stack_id"`);
1705306747072-AddOriginalFileNameIndex.js:        await queryRunner.query(`DROP INDEX "public"."IDX_4d66e76dada1ca180f67a205dc"`);
1705363967169-CreateAssetStackTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_b463c8edb01364bf2beba08ef1"`);
1711637874206-AddMemoryTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_6942ecf52d75d4273de19d2c16"`);
1711637874206-AddMemoryTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_984e5c9ab1f04d34538cd32334"`);
1715804005643-RemoveLibraryType.js:        await queryRunner.query(`DROP INDEX "public"."UQ_assets_owner_library_checksum"`);
1715804005643-RemoveLibraryType.js:        await queryRunner.query(`DROP INDEX "public"."IDX_originalPath_libraryId"`);
1724101822106-AddAssetFilesTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_asset_files_assetId"`);
1724790460210-NestedTagTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_b1a2a7ed45c29179b5ad51548a"`);
1724790460210-NestedTagTable.js:        await queryRunner.query(`DROP INDEX "public"."IDX_15fbcbc67663c6bfc07b354c22"`);

spiceratops referenced this pull request in spiceratops/k8s-gitops Sep 6, 2024
…114.0 (#951)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/immich-app/immich-server](https://github.com/immich-app/immich)
| minor | `v1.113.1` -> `v1.114.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>immich-app/immich (ghcr.io/immich-app/immich-server)</summary>

###
[`v1.114.0`](https://github.com/immich-app/immich/releases/tag/v1.114.0)

[Compare
Source](https://github.com/immich-app/immich/compare/v1.113.1...v1.114.0)

### v1.114.0

#### Highlights

Welcome to release `v1.114.0` of Immich. Who doesn't love a juicy
release on a Friday? This release focuses on additional enhancements and
bug fixes for recent new features. Please find some of the highlights
below:

-   Tag improvements (including Lightroom support)
-   Import faces from EXIF and XMP sidecars (Digikam format)
-   Better handling of timezones
-   Upload panel \*\*New look\*\*
-   Automatic database reconnection

##### Tag improvements

Since the last release, when we introduced support for tags, we have
made a few changes based on your feedback.

- We now support reading from `HierarchicalSubject`. Values will be
parsed as hierarchical tags, with `|` as a delimiter.
- We now only read from `Keywords` as a fallback when no hierarchical
tag information is available
- We have fixed a bug where you could not remove the last tag from
EXIF/XMP.

NOTE: these changes apply to the metadata extraction job. To apply them
to your photos and videos, re-run metadata extraction.

##### Import faces from metadata

This release adds the ability to read face metadata in Digikam format
during metadata extraction, increasing interoperability with other
software and laying the foundation for faces from sources other than
machine learning.

Note that there are certain limitations with these faces. These
limitations may be removed in a later release:

-   Assets that contain face metadata are skipped during face detection
-   Faces from metadata are not considered during facial recognition
-   Faces from metadata are grouped into people based on name
-   Only face metadata in Digikam format is supported

You can enable this feature by going to `Administration > Metadata
Settings`.

##### Better handling of timezones

This version fixes some issues related to how timezone offsets are
parsed and how timezones and offsets are displayed. The offset is now
parsed correctly for photos and videos taken with the "+00:00" offset
(e.g., several African countries, Iceland, Portugal/UK/Ireland in
winter).

If you notice that the "+00:00" offset is not shown correctly, please
re-run the "Extract Metadata" job on all photos and videos.

##### Upload panel

The upload panel has a new look! It works the same as before, except
that duplicates are no longer automatically cleared from the queue. They
will remain behind, along with a clickable icon, that links to the
deduped image.

| Light | Dark |
| - | - |
|
![image](https://github.com/user-attachments/assets/2911ed68-6ea2-4688-9b6e-57df7b801fc8)
|
![image](https://github.com/user-attachments/assets/9f7a65f2-6f4a-4112-bc0c-a0f43ca83716)
|

##### Automatic database reconnection

Previously, when the connection to the database was interrupted for any
reason (restart, timeout, network interruption, etc.), the server would
never reconnect. Restoring the connection required a container restart.
Now, the server will automatically try to reconnect every 5 seconds
indefinitely.


![image](https://github.com/user-attachments/assets/c0814c51-a4b0-45ac-8875-4c837acdedf9)

***

#### Support Immich

<p align="center">
<img
src="https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExbjY2eWc5Y2F0ZW56MmR4aWE0dDhzZXlidXRmYWZyajl1bWZidXZpcyZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/87CKDqErVfMqY/giphy.gif"
width="450" title="SUPPORT THE PROJECT!">
</p>

If you find the project helpful, you can support Immich by purchasing a
product key at <https://buy.immich.app>.

Cheers! 🍻

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### 🚀 Features

- feat(server): Import face regions from metadata by
[@&#8203;bugfest](https://github.com/bugfest) in
[https://github.com/immich-app/immich/pull/6455](https://github.com/immich-app/immich/pull/6455)

##### 🌟 Enhancements

- feat(server): support lightroom tags by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12288](https://github.com/immich-app/immich/pull/12288)
- feat(web): show folder navigation in root directory by
[@&#8203;ben-basten](https://github.com/ben-basten) in
[https://github.com/immich-app/immich/pull/12299](https://github.com/immich-app/immich/pull/12299)
- chore(mobile): handle sync album on duplicated by
[@&#8203;alextran1502](https://github.com/alextran1502) in
[https://github.com/immich-app/immich/pull/12173](https://github.com/immich-app/immich/pull/12173)
- feat(web): sort albums in modal by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12331](https://github.com/immich-app/immich/pull/12331)
- feat(web): add skip link to sidebar by
[@&#8203;ben-basten](https://github.com/ben-basten) in
[https://github.com/immich-app/immich/pull/12330](https://github.com/immich-app/immich/pull/12330)
- fix(server): search suggestions include partner assets by
[@&#8203;Lukasdotcom](https://github.com/Lukasdotcom) in
[https://github.com/immich-app/immich/pull/12269](https://github.com/immich-app/immich/pull/12269)
- feat(web): add download shortcut on the timeline & asset viewer by
[@&#8203;imondrag](https://github.com/imondrag) in
[https://github.com/immich-app/immich/pull/12339](https://github.com/immich-app/immich/pull/12339)

##### 🐛 Bug fixes

- fix(server): empty trash for archived assets by
[@&#8203;alextran1502](https://github.com/alextran1502) in
[https://github.com/immich-app/immich/pull/12281](https://github.com/immich-app/immich/pull/12281)
- feat(server): prefer tagslist by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12286](https://github.com/immich-app/immich/pull/12286)
- fix: remove public. reference in migration sql by
[@&#8203;alextran1502](https://github.com/alextran1502) in
[https://github.com/immich-app/immich/pull/12285](https://github.com/immich-app/immich/pull/12285)
- fix(server): public references in migrations by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12298](https://github.com/immich-app/immich/pull/12298)
- fix(web): paste event in input fields by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12297](https://github.com/immich-app/immich/pull/12297)
- fix(server): parse time zone with explicit zero offset by
[@&#8203;C-Otto](https://github.com/C-Otto) in
[https://github.com/immich-app/immich/pull/12307](https://github.com/immich-app/immich/pull/12307)
- fix(web): retain selected time zone offset also for +00:00 by
[@&#8203;C-Otto](https://github.com/C-Otto) in
[https://github.com/immich-app/immich/pull/12310](https://github.com/immich-app/immich/pull/12310)
- fix(web): handle RTL languages in the map component by
[@&#8203;zackpollard](https://github.com/zackpollard) in
[https://github.com/immich-app/immich/pull/12308](https://github.com/immich-app/immich/pull/12308)
- fix(server): auto-reconnect to database by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12320](https://github.com/immich-app/immich/pull/12320)
- fix(web): correct color for active tree item by
[@&#8203;alextran1502](https://github.com/alextran1502) in
[https://github.com/immich-app/immich/pull/12318](https://github.com/immich-app/immich/pull/12318)
- refactor(web): upload panel by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12326](https://github.com/immich-app/immich/pull/12326)
- fix(mobile): background task crashing on Android by
[@&#8203;alextran1502](https://github.com/alextran1502) in
[https://github.com/immich-app/immich/pull/12314](https://github.com/immich-app/immich/pull/12314)
- fix(server): asset no longer has tags by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12350](https://github.com/immich-app/immich/pull/12350)
- fix(web): only show valid time zones/offsets, update list based on
date by [@&#8203;C-Otto](https://github.com/C-Otto) in
[https://github.com/immich-app/immich/pull/12315](https://github.com/immich-app/immich/pull/12315)
- fix: flash bug on tag by
[@&#8203;midzelis](https://github.com/midzelis) in
[https://github.com/immich-app/immich/pull/12332](https://github.com/immich-app/immich/pull/12332)
- fix(web): showing album timeline after adding new assets by
[@&#8203;alextran1502](https://github.com/alextran1502) in
[https://github.com/immich-app/immich/pull/12354](https://github.com/immich-app/immich/pull/12354)
- fix(mobile): download asset to DCIM/Immich folder on Android by
[@&#8203;alextran1502](https://github.com/alextran1502) in
[https://github.com/immich-app/immich/pull/12355](https://github.com/immich-app/immich/pull/12355)
- fix(web): person asset grid by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12370](https://github.com/immich-app/immich/pull/12370)
- fix(server): copy video projection metadata for 360 videos by
[@&#8203;mertalev](https://github.com/mertalev) in
[https://github.com/immich-app/immich/pull/12376](https://github.com/immich-app/immich/pull/12376)
- fix(web): auth on navigation from shared link to timeline by
[@&#8203;michelheusschen](https://github.com/michelheusschen)
in
[https://github.com/immich-app/immich/pull/12385](https://github.com/immich-app/immich/pull/12385)
- fix(web): broken album thumbnail by
[@&#8203;michelheusschen](https://github.com/michelheusschen)
in
[https://github.com/immich-app/immich/pull/12381](https://github.com/immich-app/immich/pull/12381)
- fix(web): ensure shared link covers are full size by
[@&#8203;michelheusschen](https://github.com/michelheusschen)
in
[https://github.com/immich-app/immich/pull/12386](https://github.com/immich-app/immich/pull/12386)
- fix(web): show focus outline for asset thumbnails again by
[@&#8203;michelheusschen](https://github.com/michelheusschen)
in
[https://github.com/immich-app/immich/pull/12382](https://github.com/immich-app/immich/pull/12382)

##### 📚 Documentation

- docs: Fix link to ioredis docs by
[@&#8203;halkeye](https://github.com/halkeye) in
[https://github.com/immich-app/immich/pull/12291](https://github.com/immich-app/immich/pull/12291)
- docs: Add conditional album storage template information by
[@&#8203;feyst](https://github.com/feyst) in
[https://github.com/immich-app/immich/pull/12218](https://github.com/immich-app/immich/pull/12218)

##### 🌐 Translations

- feat(web): add Malay language by
[@&#8203;jrasm91](https://github.com/jrasm91) in
[https://github.com/immich-app/immich/pull/12311](https://github.com/immich-app/immich/pull/12311)
- chore(web): update translations by
[@&#8203;weblate](https://github.com/weblate) in
[https://github.com/immich-app/immich/pull/12265](https://github.com/immich-app/immich/pull/12265)

#### New Contributors

- [@&#8203;halkeye](https://github.com/halkeye) made their
first contribution in
[https://github.com/immich-app/immich/pull/12291](https://github.com/immich-app/immich/pull/12291)
- [@&#8203;bugfest](https://github.com/bugfest) made their
first contribution in
[https://github.com/immich-app/immich/pull/6455](https://github.com/immich-app/immich/pull/6455)
- [@&#8203;Lukasdotcom](https://github.com/Lukasdotcom) made
their first contribution in
[https://github.com/immich-app/immich/pull/12269](https://github.com/immich-app/immich/pull/12269)

**Full Changelog**:
https://github.com/immich-app/immich/compare/v1.113.1...

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43MC4yIiwidXBkYXRlZEluVmVyIjoiMzguNzAuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migration scripts with hardcoded public. user/schema identifier
3 participants