Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: normalize external domain #12831

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

danieldietzler
Copy link
Member

Fixes #9564. In there, @jrasm91 proposed to normalize the domain when returning it, so I did that. Wondering if it makes more sense to normalize it when stored to the DB though...?

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to write more tests. One with a trailing slash, one without, and one with a port.

@danieldietzler danieldietzler changed the title chore: normalize external domain fix: normalize external domain Sep 21, 2024
@jrasm91 jrasm91 force-pushed the chore/normalize-external-domain branch from fbfa81f to a445aab Compare September 23, 2024 15:25
@jrasm91 jrasm91 enabled auto-merge (squash) September 23, 2024 15:25
@jrasm91 jrasm91 merged commit a7719a9 into main Sep 23, 2024
35 checks passed
@jrasm91 jrasm91 deleted the chore/normalize-external-domain branch September 23, 2024 15:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email Styling and Redirection Issues in Gmail
2 participants