ADS-1441: Migrate Teamwork tap to Singer SDK and Fix Archiving Issue #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zane-patten
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Looks good there were only 2 small things that I noticed.
- I see references to 2 different licenses, not sure if that was intended but I don't know a ton about license usage.
- I thought I noticed an unused import in the streams file, but my linter is not picking anything up.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily to address an issue where data from archived projects were not getting returned and updated. However, I also took the opportunity to mgirate the Teamwork tap to the Singer SDK, which is most of the code here.
project; https://developer.teamwork.com/projects/api-v3/ref/projects/get-projects-api-v3-projectsjson#request-parameters