-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 83.95% 80.63% -3.32%
==========================================
Files 13 17 +4
Lines 405 537 +132
==========================================
+ Hits 340 433 +93
- Misses 65 104 +39
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR impressionante!
Comentários sobre coisas bobas.
|
||
result_data, result_qrcode = PixCodeService().create(location, recebedor) | ||
|
||
expected_data = """00020101021226870014br.gov.bcb.pix2565qrcodepix-h.bb.com.br/pix/v2/0c3f04a0-a41a-401e-8bb6-f6744c75a6055204000053039865802BR5920ALAN GUIACHERO BUENO6008BRASILIA62070503***63042AC9""" # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BRASILIA
é hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sim. Sempre será BRASILIA
nos pagamentos PIX!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sim. Sempre será
BRASILIA
nos pagamentos PIX!
Hardcoded sem o acento 🤦
Co-authored-by: PedroRegisPOAR <pedroalencarregis@hotmail.com>
Co-authored-by: PedroRegisPOAR <pedroalencarregis@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
||
class CobrancaPix(BaseModel): | ||
calendario: Calendario | ||
devedor: Union[PessoaPix, EmpresaPix] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
não conhecia o Union
, interessante!
] | ||
} | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse arquivo é só para teste? achei diferente o nome ser .postman_collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
É um projeto do postman. Ele tem documentado os requests de exemplo da API
data = { | ||
"expiracao": 60 * 60, # 60 segundos = 1 minuto. 60 minutos = 1h | ||
"documento_devedor": "12345678909", | ||
"nome_devedor": "Francisco da SilvaFrancisco da SilvaFrancisco da SilvaFrancisco da SilvaFrancisco da Silva", # noqa: E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Por que o nome ta assim? grande e repetido?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Só pra testar limitação de tamanho 🤣
Resumo
fix #24
Essa PR adiciona a API PIX (recebimento via PIX) do BB.
ATENÇÃO os endpoints de devolução e algumas consultas ainda estão instáveis no BB!!!!!
Adiciona também documentações necessárias para entender o funcionamento do PIX e sua geração de QR Code.