Skip to content

Add test case for import/resolve extensions order #1009

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2018
Merged

Add test case for import/resolve extensions order #1009

merged 1 commit into from
Feb 2, 2018

Conversation

silvenon
Copy link
Contributor

@silvenon silvenon commented Feb 2, 2018 •
edited
Loading

When there are multiple files with same names and different extensions, the resolver will go by extensions in the order specified in import/resolve settings.

This test case ensures that the extensions rule is correctly forcing the extension when omitting it would cause it to resolve to the wrong file.

Closes #965.

@silvenon
Add test case for import/resolve extensions order
364e841 
When there are multiple files with same names and different extensions,
the resolver will go by extensions in the order specified in
import/resolve settings.

This test case ensures that the "extensions" rule is correctly forcing
the extension when omitting it would cause it to resolve to the wrong
file.

Closes #965.
@silvenon
Copy link
Contributor Author

silvenon commented Feb 2, 2018

Let me know if more test cases are needed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.225% when pulling 364e841 on silvenon:extensions into 7852cd7 on benmosher:master.

3 similar comments
@coveralls
Copy link

coveralls commented Feb 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.225% when pulling 364e841 on silvenon:extensions into 7852cd7 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.225% when pulling 364e841 on silvenon:extensions into 7852cd7 on benmosher:master.

@coveralls
Copy link

coveralls commented Feb 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.225% when pulling 364e841 on silvenon:extensions into 7852cd7 on benmosher:master.

@ljharb ljharb merged commit bc50394 into import-js:master Feb 2, 2018
@silvenon
Copy link
Contributor Author

silvenon commented Feb 2, 2018

@ljharb could you check if this is the same reason behind your #583? My local .coffee test is passing when I reorder the extensions.

@silvenon silvenon deleted the extensions branch February 2, 2018 08:30
@ljharb
Copy link
Member

ljharb commented Feb 2, 2018

It might be; but in that example there was no other file except a .coffee.

@silvenon
Copy link
Contributor Author

silvenon commented Feb 2, 2018

Ok, if you manage to reproduce it let me know and I'll update my latest PR.

@renovate renovate bot mentioned this pull request Feb 22, 2018
Merged
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
@ljharb ljharb mentioned this pull request Sep 1, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This test/src/rules/extensions.js test should be failing with 2 errors not 1
3 participants
@silvenon @coveralls @ljharb