Use resolved package name

[mieszko4]

Should fix #496

[ljharb]

Can you add a test case that would have failed without this change?

[coveralls]

Coverage increased (+2.8%) to 97.268% when pulling e25180c on mieszko4:patch-1 into ebafcbf on benmosher:master.

[mieszko4]

@ljharb I've added the test that would have failed without fix in no-extraneous-dependencies.js. Please take a look.

[benmosher]

I'm a little nervous about letting node_modules sneak into a rule proper, though to be fair no-extra-deps is a Node-specific rule.

I'll try to come back around to this in a second pass after letting it cook in my brain for a little bit.

[ljharb]

@arcanis i'm intending to merge this soon, does it need any changes to avoid causing berry problems?

[arcanis]

From the look of it it should be compatible in most cases, since we store packages inside a standalone node_modules path (to make vendor detection easier):

/app/.yarn/cache/foo-1.0.0.zip/node_modules/foo/index.js

One caveat however: we cannot do that when people use the workspace:, link:, or portal: protocol, because they are resolved to the final path. So given the package.json:

{
  "dependencies": {
    "foo": "link:./foo"
  }
}

You'd have /app/foo, not /app/node_modules/foo.

[ljharb]

@mieszko4 this needs to be rebased. i think that the part you'll need to update now is either checkDependencyDeclaration or getModuleOriginalName.

[mieszko4]

It's been 6+ years since I created this PR.
I haven't had a need for this to be merged. And I am not sure if this PR will resolve the mentioned issue.

I think that we should just close this PR. In the future would be great if PRs could be closed or merged quicker :)

[ljharb]

@mieszko4 that's always great, but we're all unpaid volunteers here, and things take the time they take :-)

I'll close it then, thanks.

[mieszko4]

@mieszko4 that's always great, but we're all unpaid volunteers here, and things take the time they take :-)

Yeah, I totally get this. I also would check it in more detail if I had time :). Anyway, no hurt feelings, no worries.