Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[New] add config entry point for TypeScript #1257

Merged
merged 1 commit into from
Jan 23, 2019
Merged

[New] add config entry point for TypeScript #1257

merged 1 commit into from
Jan 23, 2019

Conversation

kirill-konshin
Copy link
Contributor

@kirill-konshin kirill-konshin commented Jan 7, 2019 •
edited by ljharb
Loading

Fixes #1256

@kirill-konshin kirill-konshin mentioned this pull request Jan 7, 2019
Closed
@ljharb ljharb changed the title Fix for #1256 [New] add config entry point for TypeScript Jan 7, 2019
ljharb
ljharb approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@kirill-konshin
Copy link
Contributor Author

kirill-konshin commented Jan 7, 2019 •
edited
Loading

There was a broken CI, I have pushed an update for that. Some tests are still failing, no idea why, since I did not touch anything existing...

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

6 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls
Copy link

coveralls commented Jan 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.308% when pulling 5c5439d on kirill-konshin:master into 767f01a on benmosher:master.

@ljharb
Copy link
Member

ljharb commented Jan 7, 2019

Tests are failing due to #1254.

@kirill-konshin
Copy link
Contributor Author

Whew ) will you merge with failing tests?

@ljharb
Copy link
Member

ljharb commented Jan 7, 2019

No, this will be blocked on fixing that.

@kirill-konshin
Copy link
Contributor Author

Okay, is there any ETA then?

@kirill-konshin
Copy link
Contributor Author

Ping

@ljharb
Copy link
Member

ljharb commented Jan 22, 2019

@kirill-konshin the tests are fixed; can you rebase this PR?

@kirill-konshin
Copy link
Contributor Author

Done, waiting for CI

@kirill-konshin
Copy link
Contributor Author

All green

@ljharb ljharb requested review from benmosher and jfmengels January 22, 2019 23:16
@benmosher benmosher merged commit 1ec80fa into import-js:master Jan 23, 2019
@kirill-konshin
Copy link
Contributor Author

So it's not in 2.15 yet, do you have any estimates when it will be released?

@ljharb
Copy link
Member

ljharb commented Jan 23, 2019

it was merged only 10 hours ago, it might take awhile til the next release.

@kirill-konshin
Copy link
Contributor Author

Yep, I received the notification. Just wanted to check the estimates. No rush.

@jaridmargolin jaridmargolin mentioned this pull request Feb 6, 2019
Closed
@kirill-konshin
Copy link
Contributor Author

@ljharb do you have any estimate when this will be released? Almost a month has passed...

@kirill-konshin
Copy link
Contributor Author

Ping!

@Hotell Hotell mentioned this pull request Jul 3, 2019
Closed
@digeomel

This comment has been minimized.

# to view
@ljharb

This comment has been minimized.

# to view
@digeomel

This comment has been minimized.

# to view
@ljharb

This comment has been minimized.

# to view
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@benmosher benmosher benmosher approved these changes

@jfmengels jfmengels Awaiting requested review from jfmengels

Assignees
No one assigned
Labels
semver-minor typescript
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce additional config for TypeScript
5 participants
@kirill-konshin @coveralls @ljharb @digeomel @benmosher